Create registration flow for Print promotion#3280
Open
akinsola-guardian wants to merge 57 commits intomainfrom
Open
Create registration flow for Print promotion#3280akinsola-guardian wants to merge 57 commits intomainfrom
akinsola-guardian wants to merge 57 commits intomainfrom
Conversation
…oller. For /signin/password, /reauthenticate, /reauthenticate/password use the sign in only controller
…d cookie state is not available update a couple of e2e test assertions to work with the new passcode page
update some more of the register e2e test assertions to work with the new signin or register passcode route
amend signin controller encrypted cookie signinOrRegister state based on where the journey started
…r flow for people going through the registration journey in order for them to set consents and newsletter consents
…statements, refactor large if else block to be a series of ifs with returns to hopefully make the code more readable
…nal/immutable-data eslint rule
…at it only redirects you to the specific route you came from or the combined /signin route. This should mitigate any user enumeration attempts
akinsola-guardian
force-pushed
the
al/print-promo
branch
from
30f1f40 to
3e529ae
Compare
akinsola-guardian
changed the base branch from
main
to
rb/combine-sign-in-and-create-account
akinsola-guardian
force-pushed
the
al/print-promo
branch
from
78bf110 to
3f5e45a
Compare
akinsola-guardian
force-pushed
the
al/print-promo
branch
from
3f5e45a to
688e871
Compare
akinsola-guardian
force-pushed
the
al/print-promo
branch
4 times, most recently
from
549d117 to
4978ca9
Compare
akinsola-guardian
force-pushed
the
al/print-promo
branch
3 times, most recently
from
84f4223 to
54df584
Compare
akinsola-guardian
force-pushed
the
al/print-promo
branch
from
54df584 to
560dbfd
Compare
akinsola-guardian
force-pushed
the
al/print-promo
branch
5 times, most recently
from
c1997d5 to
0669d1e
Compare
akinsola-guardian
force-pushed
the
al/print-promo
branch
from
0669d1e to
23c5450
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this change?
This PR introduces a registration flow for the Print Promotion campaign, using a new
appClientIdprintpromo.printpromovalue:appClientIdto be used identify users on the print-promo flow and to update registration platform.print-promowhich points to the Register page.welcome/print-promopage and email template for print promo signupsImages
Registration page on /print-promo/welcome/print promo for existing users/welcome/print promo for new usersEmail sent on landing on /welcome/print-promo