Migrate mobile-purchases-soft-opt-in-acquisitions from CloudFormation to native CDK#1940
Draft
andresilva-guardian wants to merge 3 commits intomainfrom
Draft
Conversation
andresilva-guardian
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR completes the migration of the mobile-purchases-soft-opt-in-acquisitions infrastructure from CloudFormation/SAM deployment to a native CDK stack, improving maintainability and consistency with other Guardian projects.
What's Changed
🆕 New Files
cdk/lib/mobile-purchases-soft-opt-in-acquisitions.ts- Complete CDK stack implementation for soft opt-in acquisitions infrastructurecdk/lib/mobile-purchases-soft-opt-in-acquisitions.test.ts- Unit tests for the soft opt-in acquisitions stack📝 Modified Files
cdk/bin/cdk.ts- Added soft opt-in acquisitions stack instantiations for CODE and PROD environments🗑️ Files to Remove (Post-Deployment)
cloudformation.yaml- Original CloudFormation template section for soft opt-in acquisitions (will be removed after successful deployment)Breaking Changes
None - this is a like-for-like migration maintaining full backward compatibility with existing Lambda code and configuration.
Related Issues
This addresses the ongoing initiative to migrate all CloudFormation templates to native CDK implementations across the Value Team's repositories.
Note: The original CloudFormation template section will be removed in a follow-up PR after successful deployment and verification of the CDK implementation.