Merge pull request #1436 from guardian/jm/banner-colour-palettes

add new colour codes to banner design types

Author: juabara

.changeset/lovely-parrots-tickle.md

@@ -0,0 +1,5 @@
+---
+'@guardian/support-dotcom-components': minor
+---
+
+add new colour properties to the banner design

src/server/factories/bannerDesign.ts

@@ -66,10 +66,8 @@ export default Factory.define<BannerDesignFromTool>(() => ({
             },
         },
         ticker: {
-            text: stringToHexColour('052962'),
             filledProgress: stringToHexColour('052962'),
             progressBarBackground: stringToHexColour('ffffff'),
-            goalMarker: stringToHexColour('000000'),
             headlineColour: stringToHexColour('000000'),
             totalColour: stringToHexColour('000000'),
             goalColour: stringToHexColour('000000'),

src/shared/types/props/design.ts

@@ -33,6 +33,9 @@ const choiceCardsSchema = z.object({
     buttonSelectColour: hexColourSchema.nullish(),
     buttonSelectTextColour: hexColourSchema.nullish(),
     buttonSelectBorderColour: hexColourSchema.nullish(),
+    buttonSelectMarkerColour: hexColourSchema.nullish(),
+    pillTextColour: hexColourSchema.nullish(),
+    pillBackgroundColour: hexColourSchema.nullish(),
     kind: z.literal('ChoiceCards'),
 });
 
@@ -88,10 +91,8 @@ export interface CtaDesign {
 }
 
 interface TickerDesign {
-    text: HexColour; //deprecated
     filledProgress: HexColour;
     progressBarBackground: HexColour;
-    goalMarker: HexColour; //deprecated
     headlineColour: HexColour; //new
     totalColour: HexColour; //new
     goalColour: HexColour; //new
@@ -116,6 +117,9 @@ interface ChoiceCardsDesign {
     buttonSelectColour?: HexColour;
     buttonSelectTextColour?: HexColour;
     buttonSelectBorderColour?: HexColour;
+    buttonSelectMarkerColour?: HexColour;
+    pillTextColour?: HexColour;
+    pillBackgroundColour?: HexColour;
 }
 type Visual = BannerDesignImage | ChoiceCardsDesign;