Hide epic and banners for info pages#1298
Merged
LAKSHMIRPILLAI merged 4 commits intomainfrom Feb 27, 2025
Merged
Conversation
tomrf1
reviewed
Feb 27, 2025
| isSignedIn: boolean; | ||
| hasConsented: boolean; | ||
| abandonedBasket?: AbandonedBasket; | ||
| pageId?: string; |
Member
There was a problem hiding this comment.
shall we do this for the gutter ask as well, just in case?
tomrf1
reviewed
Feb 27, 2025
| } | ||
|
|
||
| if ( | ||
| targeting.pageId === 'info/privacy' || |
Member
There was a problem hiding this comment.
let's put this in a shared function since it's being used at least twice
LAKSHMIRPILLAI
deleted the
lp-hide-support-messages-on-info-pages-sdc
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this change?
We need to disable RRCP support messages on pages like Privacy | The Guardian like Privacy | The Guardian
See green section here for full list: https://docs.google.com/spreadsheets/d/1KdwxnOecrV-2j3X-mX_kkvLgupPH8DvBgvEH-D-cRWg/edit?gid=0#gid=0Connect your Google account
Trello card
Out of the list we are making this change for the below pageIds
how to test
Tested using Postman
Before change
After change