Conversation
LAKSHMIRPILLAI
approved these changes
Mar 3, 2025
shtukas
approved these changes
Mar 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently we scale up when average cpu hits 40%. This is bad because:
a) cpu clearly isn't the only relevant factor when considering error spikes
b) it soon scales back down because cpu goes down, even if traffic is still high
Instead we can use the
RequestCountPerTargetmetric (documented here) to scale up when traffic increases. This is more suitable for e.g. the morning traffic spike.I've set it to 20,000 requests per target (where target means an ec2 instance).
This means e.g. at 80k requests per minute the ASG will have 4 instances.
I've reset the minimum count to 3, so during the night (UTC) when it's quiet it'll go back to 3 instances.
Recent requests per minute:
