Conversation
shtukas
force-pushed
the
ph-20250823-0001-prelude
branch
from
088bfe1 to
77080e0
Compare
shtukas
force-pushed
the
ph-20250823-0001-prelude
branch
from
77080e0 to
cbcfe9a
Compare
tomrf1
approved these changes
Aug 26, 2025
Member
tomrf1
left a comment
tomrf1
left a comment
There was a problem hiding this comment.
👍 union of strings is fine and consistent with the rest of the codebase
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Here we move the
GateTypefrom an enum to a different, isomorphic, type of enum.This is a bit sad, because I really like the purity of
GateTypeas it was defined, but the linter keeps confusing itself about whether GateType is a type or something else and make the developer experience awful. This solves it.This is another preliminary PR for #1414