Skip to content

Prices fetch from supportFrontend removed #1575

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AnastasiiaBalenko merged 2 commits into from
Mar 4, 2026
Merged

Prices fetch from supportFrontend removed #1575

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
680409e
Prices fetch from supportFrontend removed
AnastasiiaBalenko Mar 2, 2026
af5f671
prices prop removed from banner props
AnastasiiaBalenko Mar 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions src/server/api/bannerRouter.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@ import type {
BannerProps,
BannerTargeting,
BannerTest,
Prices,
TestTracking,
Tracking,
} from '../../shared/types';
Expand Down Expand Up @@ -47,7 +46,6 @@ interface BannerDataResponse {
export const buildBannerRouter = (
channelSwitches: ValueProvider<ChannelSwitches>,
tickerData: TickerDataProvider,
productPrices: ValueProvider<Prices | undefined>,
bannerTests: ValueProvider<BannerTest[]>,
bannerDeployTimes: BannerDeployTimesProvider,
choiceCardAmounts: ValueProvider<AmountsTests>,
Expand Down Expand Up @@ -147,7 +145,6 @@ export const buildBannerRouter = (
tickerSettings,
separateArticleCount: variant.separateArticleCount,
separateArticleCountSettings: variant.separateArticleCountSettings,
prices: productPrices.get(),
Copy link
Member

@tomrf1 tomrf1 Mar 3, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we can also remove this field from the BannerProps model

choiceCardsSettings,
choiceCardAmounts: variantAmounts, // deprecated, to be removed soon
design,
Expand Down
22 changes: 0 additions & 22 deletions src/server/productPrices.ts
View file
Open in desktop

This file was deleted.

4 changes: 0 additions & 4 deletions src/server/server.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,6 @@ import {
logging as loggingMiddleware,
} from './middleware';
import { buildProductCatalogReloader } from './productCatalog';
import { buildProductPricesReloader } from './productPrices';
import { buildBanditDataReloader } from './selection/banditData';
import { buildBannerDeployTimesReloader } from './tests/banners/bannerDeployTimes';
import { buildBannerDesignsReloader } from './tests/banners/bannerDesigns';
Expand Down Expand Up @@ -81,7 +80,6 @@ const buildApp = async (): Promise<Express> => {
liveblogEpicTests,
choiceCardAmounts,
tickerData,
productPrices,
bannerTests,
bannerDeployTimes,
headerTests,
Expand All @@ -96,7 +94,6 @@ const buildApp = async (): Promise<Express> => {
buildEpicLiveblogTestsReloader(),
buildChoiceCardAmountsReloader(),
buildTickerDataReloader(stage),
buildProductPricesReloader(),
buildBannerTestsReloader(),
buildBannerDeployTimesReloader(),
buildHeaderTestsReloader(),
Expand Down Expand Up @@ -136,7 +133,6 @@ const buildApp = async (): Promise<Express> => {
buildBannerRouter(
channelSwitches,
tickerData,
productPrices,
bannerTests,
bannerDeployTimes,
choiceCardAmounts,
Expand Down
43 changes: 0 additions & 43 deletions src/server/utils/supportFrontend.test.ts
View file
Open in desktop

This file was deleted.

25 changes: 0 additions & 25 deletions src/server/utils/supportFrontend.ts
View file
Open in desktop

This file was deleted.