migrate from flask to fast api for uvicorn and asgi support #75
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dtam
changed the title
CalebCourier
previously approved these changes
Sep 18, 2024
|
Code looks good, some of the tests are not happy though |
| *args, | ||
| **payload, | ||
| ) | ||
| if inspect.iscoroutinefunction(guard): |
There was a problem hiding this comment.
Super pedantic, but any reason to not call it once and inspect on the result? albeit, I think the type checker gets a little more angry with that method
CalebCourier
approved these changes
Sep 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
missing pg suport
Pull Request Type
Link to Notion Task or Github Issue
Summary of Feature(s)
Summary of Bug Fix(es)
Previous Behaviour
Description of the bug and it's impact
New Behaviour
Description of the bug fix and it's impact
Other details
Dependencies