Skip to content

Conversation

@dtam
Copy link
Contributor

@dtam dtam commented Sep 25, 2024

No description provided.

Copy link
Contributor

@JosephCatrambone JosephCatrambone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving, but it would be good to get eyes from Alejandro, too.

Copy link
Member

@AlejandroEsquivel AlejandroEsquivel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems consistent with async_trace, looks good to me 👍🏼 there just seem to be some typing actions failing

@dtam dtam changed the title add missing awaits remove unnecessary awaits on telem decorator Sep 25, 2024
@JosephCatrambone JosephCatrambone merged commit 0ff4f6f into main Sep 26, 2024
12 checks passed
@JosephCatrambone JosephCatrambone deleted the fix_async_stream_await branch September 26, 2024 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants