Skip to content

remove unnecessary awaits on telem decorator #1095

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 26, 2024
Merged

remove unnecessary awaits on telem decorator #1095

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
12b2872
add missing awaits
dtam Sep 25, 2024
047f935
remove extra coroutine
dtam Sep 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions guardrails/hub_telemetry/hub_tracing.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
Any,
Dict,
Optional,
AsyncGenerator,
)

from opentelemetry.trace import Span
Expand Down Expand Up @@ -224,7 +225,7 @@ def wrapper(*args, **kwargs):
return decorator


async def _run_async_gen(fn, *args, **kwargs):
async def _run_async_gen(fn, *args, **kwargs) -> AsyncGenerator[Any, None]:
gen = fn(*args, **kwargs)
async for item in gen:
yield item
Expand All @@ -238,7 +239,7 @@ def async_trace_stream(
):
def decorator(fn):
@wraps(fn)
async def wrapper(*args, **kwargs):
def wrapper(*args, **kwargs):
hub_telemetry = HubTelemetry()
if hub_telemetry._enabled and hub_telemetry._tracer is not None:
with hub_telemetry._tracer.start_span(
Expand Down
Loading