Skip to content

use the batch exporter instead of the simple one #1115

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 7, 2024
Merged

use the batch exporter instead of the simple one #1115

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e993d69
use the batch exporter instead of the simple one
dtam Oct 5, 2024
0fd1e72
fix tests
dtam Oct 7, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion guardrails/run/async_runner.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -281,7 +281,7 @@ async def async_call(
return llm_response

# TODO: Refactor this to use inheritance and overrides
# @async_trace(name="/validation", origin="AsyncRunner.async_validate")
@async_trace(name="/validation", origin="AsyncRunner.async_validate")
async def async_validate(
self,
iteration: Iteration,
Expand Down
6 changes: 3 additions & 3 deletions guardrails/utils/hub_telemetry_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
)
from opentelemetry.sdk.resources import SERVICE_NAME, Resource
from opentelemetry.sdk.trace import TracerProvider
from opentelemetry.sdk.trace.export import ConsoleSpanExporter, SimpleSpanProcessor
from opentelemetry.sdk.trace.export import ConsoleSpanExporter, BatchSpanProcessor
from opentelemetry.trace.propagation.tracecontext import TraceContextTextMapPropagator
from opentelemetry.trace.propagation import set_span_in_context

Expand Down Expand Up @@ -74,9 +74,9 @@ def initialize_tracer(
self._tracer_provider = TracerProvider(resource=self._resource)

if export_locally:
self._processor = SimpleSpanProcessor(ConsoleSpanExporter())
self._processor = BatchSpanProcessor(ConsoleSpanExporter())
else:
self._processor = SimpleSpanProcessor(
self._processor = BatchSpanProcessor(
OTLPSpanExporter(endpoint=self._endpoint)
)

Expand Down
13 changes: 13 additions & 0 deletions tests/integration_tests/test_telemetry.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,6 +81,12 @@ def test_hub_traces_go_to_hub_telem_sink(self, mocker):
"guardrails.utils.hub_telemetry_utils.OTLPSpanExporter",
return_value=hub_exporter,
)
hub_processor = SimpleSpanProcessor(hub_exporter)

mocker.patch(
"guardrails.utils.hub_telemetry_utils.BatchSpanProcessor",
return_value=hub_processor,
)

from guardrails import Guard
from tests.integration_tests.test_assets.validators import LowerCase
Expand Down Expand Up @@ -126,6 +132,13 @@ def test_no_cross_contamination(self, mocker):
)
mock_hub_otlp_span_exporter.return_value = hub_exporter

hub_processor = SimpleSpanProcessor(hub_exporter)

mocker.patch(
"guardrails.utils.hub_telemetry_utils.BatchSpanProcessor",
return_value=hub_processor,
)

from guardrails.telemetry import default_otel_collector_tracer
from guardrails import Guard
from tests.integration_tests.test_assets.validators import LowerCase
Expand Down
Loading