Skip to content

Comments

Add SSO configuration support to helm chart#153

Open
flo-mic wants to merge 9 commits intoguerzon:mainfrom
flo-mic:feature/sso
Open

Add SSO configuration support to helm chart#153
flo-mic wants to merge 9 commits intoguerzon:mainfrom
flo-mic:feature/sso

Conversation

@flo-mic
Copy link

@flo-mic flo-mic commented Feb 24, 2025

As SSO to Vaultwarden using OpenID Connect will be soon available via the PR dani-garcia/vaultwarden#3899, it would be nice to control this with the recommended helm chart of vaultwarden. Therefore this PR adds the newly added parameters to the chart and enables SSO configuration.

The PR is already combining the settings from the original PR as well as the additions which @Timshel is nicely maintaining here https://github.com/Timshel/vaultwarden until the initial PR was merged.

@guerzon
Copy link
Owner

guerzon commented Mar 6, 2025

Hi @flo-mic, first of all, thanks for the PR.

I was waiting for dani-garcia/vaultwarden#3899 to be merged first but as of today it's not yet merged. I do not see harm in merging this PR but it could cause confusion/inconsistency when the values are already available and the chart documentation discusses the SSO feature but in reality the latest available image still does not support said feature. With that, I would wait until the feature is merged.

As a review point: please bump the chart version to 0.32.0. Of course when the PR gets merged, the app version in Chart.yaml (and ideally image.tag in values.yaml) has to be updated as well.

Also: if you don't mind, can you run ./generate-readme.sh (requires Docker) as well?

Thanks

@flo-mic
Copy link
Author

flo-mic commented Mar 15, 2025

Hi @guerzon I agree to wait with the merge of this PR to avoid confusions. Also I have updated the chart version and run the generate-readme script.

@guerzon
Copy link
Owner

guerzon commented Aug 10, 2025

Hi @flo-mic, dani-garcia/vaultwarden#3899 has now been merged. Feel free to revisit this PR and rebase. Thanks

Edit: the feature has not been released yet, image containing the feature will be released in 2-4 weeks.

@Timshel
Copy link

Timshel commented Aug 11, 2025

I'll mention that all the sso.roles and sso.organizations config/features are not part of the merged PR.

@mreho
Copy link

mreho commented Sep 8, 2025

Hello @flo-mic, any news about this PR ? Thank you in advance ! 😃

@flo-mic
Copy link
Author

flo-mic commented Sep 13, 2025

Hey, appologize the delay. I updated the PR and fixed the linting issues. Regarding the support for sso.roles and sso.organizations should I drop this as it was not part of the initial PR from Timshel?

@guerzon
Copy link
Owner

guerzon commented Sep 13, 2025

Hey, appologize the delay. I updated the PR and fixed the linting issues. Regarding the support for sso.roles and sso.organizations should I drop this as it was not part of the initial PR from Timshel?

@flo-mic no worries!

I would say yes let's drop them from this PR for now

@flo-mic
Copy link
Author

flo-mic commented Sep 14, 2025

I removed support for roles and organizations as suggested.

@guerzon
Copy link
Owner

guerzon commented Sep 18, 2025

Thanks @flo-mic, let's wait for the release.

@mreho
Copy link

mreho commented Dec 28, 2025

Hello @guerzon, Vaultwarden v1.35.0 has just been released including SSO login via OIDC, should be ready to merge now 😃

@guerzon
Copy link
Owner

guerzon commented Jan 10, 2026

@flo-mic can you please revisit the PR and rebase? Thanks

@mreho
Copy link

mreho commented Jan 27, 2026

Hello @flo-mic, any news please ?

@guerzon
Copy link
Owner

guerzon commented Jan 29, 2026

If anybody wants to resubmit the PR, that would be fine as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants