Add SSO configuration support to helm chart#153
Add SSO configuration support to helm chart#153flo-mic wants to merge 9 commits intoguerzon:mainfrom
Conversation
|
Hi @flo-mic, first of all, thanks for the PR. I was waiting for dani-garcia/vaultwarden#3899 to be merged first but as of today it's not yet merged. I do not see harm in merging this PR but it could cause confusion/inconsistency when the values are already available and the chart documentation discusses the SSO feature but in reality the latest available image still does not support said feature. With that, I would wait until the feature is merged. As a review point: please bump the chart version to Also: if you don't mind, can you run Thanks |
|
Hi @guerzon I agree to wait with the merge of this PR to avoid confusions. Also I have updated the chart version and run the generate-readme script. |
|
Hi @flo-mic, dani-garcia/vaultwarden#3899 has now been merged. Feel free to revisit this PR and rebase. Thanks Edit: the feature has not been released yet, image containing the feature will be released in 2-4 weeks. |
|
I'll mention that all the |
|
Hello @flo-mic, any news about this PR ? Thank you in advance ! 😃 |
|
Hey, appologize the delay. I updated the PR and fixed the linting issues. Regarding the support for |
@flo-mic no worries! I would say yes let's drop them from this PR for now |
|
I removed support for roles and organizations as suggested. |
|
Thanks @flo-mic, let's wait for the release. |
|
Hello @guerzon, Vaultwarden v1.35.0 has just been released including SSO login via OIDC, should be ready to merge now 😃 |
|
@flo-mic can you please revisit the PR and rebase? Thanks |
|
Hello @flo-mic, any news please ? |
|
If anybody wants to resubmit the PR, that would be fine as well. |
As SSO to Vaultwarden using OpenID Connect will be soon available via the PR dani-garcia/vaultwarden#3899, it would be nice to control this with the recommended helm chart of vaultwarden. Therefore this PR adds the newly added parameters to the chart and enables SSO configuration.
The PR is already combining the settings from the original PR as well as the additions which @Timshel is nicely maintaining here https://github.com/Timshel/vaultwarden until the initial PR was merged.