Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions .github/workflows/code_quality.yml
Original file line number Diff line number Diff line change
Expand Up @@ -65,8 +65,6 @@ jobs:
}
})

# Have a separate workflow because we don't want to enforce this at all
# It will have too many errors initially and is likely to deter contributors
ruff-linting:
name: Linting with ruff
runs-on: ubuntu-latest
Expand All @@ -81,10 +79,13 @@ jobs:
run: pip install -e .[dev]
- name: Run ruff linting
shell: bash
id: ruff_lint
continue-on-error: true
run: |
ruff check

if ! ruff check; then
echo "::warning title=ruff lint::Ruff found linting issues"
exit 78 # no longer works in github, but would mark action step with a warning
fi

run-mypy:
name: Run informational mypy
Expand Down
2 changes: 1 addition & 1 deletion ruff.toml
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ exclude = [
select = [
"B", # flake8-bugbear
"I", # isort
# "ARG", # flake8-unused-arguments
"ARG", # flake8-unused-arguments
"C4", # flake8-comprehensions
"F401", # flake8-unused-imports
"F541", # flake8 f-string without any placeholders
Expand Down
Loading