Add completion and instruct engines for GoogleAI #822
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I propose merging these commits that add in the missing completion and instruct engines for GoogleAI. With these inclusions, Gemini can be more fully supported.
The one hitch with this implementation is that Google AI Studio uses the same model name for different modalities like completion vs instruct vs chat, so it's not possible to determine which to use in the generalized class definition based on the model name alone as it is with other LLM services.
Unless maintainer has a better idea, I have decided to handle this situation by implementing with GoogleAIChat by default (as it was before), allowing for users specify different modalities by constructing GoogleAICompletion or GoogleAIInstruction directly.