Merged
Conversation
[why] We can simply replace all occurrences of 'libgul14' inside the meson.build files by 'gul17'. This is correct for both wrap dependencies and pkgconfig oned. The main dependency exported by GUL17's meson.build is still called libgul_dep, not gul17_dep, so it is not necessary to write a special case for it. Signed-off-by: Lars Froehlich <lars.froehlich@desy.de>
[why] To provide a fallback for GUL17. Signed-off-by: Lars Froehlich <lars.froehlich@desy.de>
[why] The dev-doocs-libgul14 dependency should be replaced by one to gul17-dev. Signed-off-by: Lars Froehlich <lars.froehlich@desy.de>
alt-graph
requested review from
Finii,
Seim2k17,
Copilot,
ohensler and
soerengrunewald
There was a problem hiding this comment.
Pull Request Overview
This PR improves the migration script from GUL14 to GUL17 by updating dependency names and adding support for generating a gul17 wrap file when a subprojects folder exists.
- Adds a new function to create a gul17.wrap file.
- Updates the Debian control file to fix package dependency names.
- Adjusts replacement patterns in meson.build files.
Proposed-by: Fini Jastrow <ulf.fini.jastrow@desy.de> Signed-off-by: Lars Froehlich <lars.froehlich@desy.de>
Member
Author
|
Thanks for the review, @Finii! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These are a few improvements for the GUL14-to-GUL17 migration script. Among other things, the PR
controlfile, andmeson.buildfiles.