Fix exclusion of paths in GUL14 migration script#33
Merged
Conversation
[why]
The code tried to exclude paths with a leading "./${dir}" from the recursive
search with find. The correct prefix would simply be ${dir}.
Signed-off-by: Lars Froehlich <lars.froehlich@desy.de>
alt-graph
requested review from
Finii,
Seim2k17,
Copilot,
ohensler and
soerengrunewald
There was a problem hiding this comment.
Pull Request Overview
This PR updates the GUL14 migration script so that path exclusions in the find commands work correctly.
- The script now properly excludes directories by using "${dir}/..." syntax instead of using a leading "./${dir}/...".
- An echo message was added in the handle_source_file function when "make_overload_set" is found.
Finii
approved these changes
Jun 3, 2025
Member
Finii
left a comment
Finii
left a comment
There was a problem hiding this comment.
Looks good, sorry for (my) bug.
But a different solution suggestion; apply ad lib.
Member
Author
|
Thanks, @Finii! I'll merge this as-is. It just needs to be good enough. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The code tried to exclude paths with a leading "./${dir}" from the recursive search with find. The correct prefix would simply be ${dir}.