S3 - add daily and monthly tests for South Fork wave#125
Open
abkfenris wants to merge 2 commits intoempire-nansfrom
Open
S3 - add daily and monthly tests for South Fork wave#125abkfenris wants to merge 2 commits intoempire-nansfrom
abkfenris wants to merge 2 commits intoempire-nansfrom
Conversation
This was referenced Jan 28, 2026
Codecov Report❌ Patch coverage is
❌ Your patch check has failed because the patch coverage (83.33%) is below the target coverage (90.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## empire-nans #125 +/- ##
===============================================
+ Coverage 76.65% 77.23% +0.58%
===============================================
Files 29 30 +1
Lines 848 918 +70
Branches 21 21
===============================================
+ Hits 650 709 +59
- Misses 196 207 +11
Partials 2 2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There are some NANs getting passed along with Empire, this makes sure they are dropped out, so that processing can continue. xref gulfofmaine/NERACOOS_ERDDAP_K8S#1185
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Works on #101
This is part 3 of 3 in a stack made with GitButler: