Skip to content

S3 - add daily and monthly tests for South Fork wave#125

Open
abkfenris wants to merge 2 commits intoempire-nansfrom
s3_south_fork
Open

S3 - add daily and monthly tests for South Fork wave#125
abkfenris wants to merge 2 commits intoempire-nansfrom
s3_south_fork

Conversation

@abkfenris
Copy link
Member

@abkfenris abkfenris commented Jan 28, 2026

Works on #101


This is part 3 of 3 in a stack made with GitButler:

This was referenced Jan 28, 2026
@codecov
Copy link

codecov bot commented Jan 28, 2026

Codecov Report

❌ Patch coverage is 83.33333% with 14 lines in your changes missing coverage. Please review.
✅ Project coverage is 77.23%. Comparing base (e9bdc14) to head (625c67c).
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
pipeline/s3_timeseries/tests/test_south_fork.py 77.04% 14 Missing ⚠️

❌ Your patch check has failed because the patch coverage (83.33%) is below the target coverage (90.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@               Coverage Diff               @@
##           empire-nans     #125      +/-   ##
===============================================
+ Coverage        76.65%   77.23%   +0.58%     
===============================================
  Files               29       30       +1     
  Lines              848      918      +70     
  Branches            21       21              
===============================================
+ Hits               650      709      +59     
- Misses             196      207      +11     
  Partials             2        2              
Flag Coverage Δ
common 53.57% <ø> (ø)
s3_timeseries 65.80% <83.33%> (+1.94%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@abkfenris abkfenris marked this pull request as ready for review February 3, 2026 14:35
There are some NANs getting passed along with Empire, this makes sure they are dropped out, so that processing can continue.

xref gulfofmaine/NERACOOS_ERDDAP_K8S#1185
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant