fix: JernArc detect and modify global/local tangent directions as appropriate#1226
Merged
jdegenstein merged 1 commit intogumyr:devfrom Feb 6, 2026
Merged
fix: JernArc detect and modify global/local tangent directions as appropriate#1226jdegenstein merged 1 commit intogumyr:devfrom
JernArc detect and modify global/local tangent directions as appropriate#1226jdegenstein merged 1 commit intogumyr:devfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## dev #1226 +/- ##
=======================================
Coverage 95.43% 95.44%
=======================================
Files 34 34
Lines 11549 11551 +2
=======================================
+ Hits 11022 11025 +3
+ Misses 527 526 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #1225 and resolves #997
I have added one additional test case derived from issue #1225
Essentially what this PR does is introduce different logic to check if a tuple of length 2 (i.e. a 2-tuple) is supplied to JernArc as a tangent direction. If so it applies a transformation to this tangent direction to put it into the global coordinate system. If a 3-tuple or Vector is supplied this transformation is skipped as it is assumed these are already in the global coordinate system.
More context for this is also available in an older PR here #644
cc @jwagenet