Skip to content

fix: JernArc detect and modify global/local tangent directions as appropriate#1226

Merged
jdegenstein merged 1 commit intogumyr:devfrom
jdegenstein:fix_jernarc
Feb 6, 2026
Merged

fix: JernArc detect and modify global/local tangent directions as appropriate#1226
jdegenstein merged 1 commit intogumyr:devfrom
jdegenstein:fix_jernarc

Conversation

@jdegenstein
Copy link
Collaborator

Resolves #1225 and resolves #997

I have added one additional test case derived from issue #1225

Essentially what this PR does is introduce different logic to check if a tuple of length 2 (i.e. a 2-tuple) is supplied to JernArc as a tangent direction. If so it applies a transformation to this tangent direction to put it into the global coordinate system. If a 3-tuple or Vector is supplied this transformation is skipped as it is assumed these are already in the global coordinate system.

More context for this is also available in an older PR here #644

cc @jwagenet

@codecov
Copy link

codecov bot commented Feb 5, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.44%. Comparing base (42cfc16) to head (9dc6409).
⚠️ Report is 5 commits behind head on dev.

Additional details and impacted files
@@           Coverage Diff           @@
##              dev    #1226   +/-   ##
=======================================
  Coverage   95.43%   95.44%           
=======================================
  Files          34       34           
  Lines       11549    11551    +2     
=======================================
+ Hits        11022    11025    +3     
+ Misses        527      526    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@jdegenstein jdegenstein requested a review from gumyr February 5, 2026 16:35
@jdegenstein jdegenstein merged commit 5c164c0 into gumyr:dev Feb 6, 2026
20 checks passed
@jdegenstein jdegenstein deleted the fix_jernarc branch February 6, 2026 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

JernArc fails in non-Plane.XY BuildLine context JernArc localization bug

1 participant