Skip to content

Added API to get expected colors for Macbeth color charts in MCC module #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: 5.x
Choose a base branch
from
Open

Added API to get expected colors for Macbeth color charts in MCC module #1

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions modules/mcc/include/opencv2/mcc/ccm.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -392,6 +392,13 @@ class CV_EXPORTS_W ColorCorrectionModel
*/
CV_WRAP ColorCorrectionModel(const Mat& src, Mat colors, COLOR_SPACE ref_cs, Mat colored);

/** @brief Set the reference color using a built-in (CONST_COLOR) reference color chart.
* This lets you change the reference color patch data after you’ve constructed
* the model or at any time.
@param output original color values
*/
void getColorMatrix(CONST_COLOR constcolor, Mat& output);

/** @brief set ColorSpace
@note It should be some RGB color space;
Supported list of color cards:
Expand Down
10 changes: 10 additions & 0 deletions modules/mcc/src/ccm.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,6 +101,7 @@ class ColorCorrectionModel::Impl

void getColor(Mat& img_, bool islinear = false);
void getColor(CONST_COLOR constcolor);
void getColorMatrix(CONST_COLOR constcolor, Mat& output);
void getColor(Mat colors_, COLOR_SPACE cs_, Mat colored_);
void getColor(Mat colors_, COLOR_SPACE ref_cs_);

Expand Down Expand Up @@ -302,6 +303,11 @@ void ColorCorrectionModel::Impl::getColor(CONST_COLOR constcolor)
{
dst = (GetColor::getColor(constcolor));
}
void ColorCorrectionModel::Impl::getColorMatrix(CONST_COLOR constcolor, Mat& output)
{
dst = (GetColor::getColor(constcolor));
output = dst->colors;
}
void ColorCorrectionModel::Impl::getColor(Mat colors_, COLOR_SPACE ref_cs_)
{
dst.reset(new Color(colors_, *GetCS::getInstance().get_cs(ref_cs_)));
Expand All @@ -310,6 +316,10 @@ void ColorCorrectionModel::Impl::getColor(Mat colors_, COLOR_SPACE cs_, Mat colo
{
dst.reset(new Color(colors_, *GetCS::getInstance().get_cs(cs_), colored_));
}
void ColorCorrectionModel::getColorMatrix(CONST_COLOR constcolor, Mat& output)
{
p->getColorMatrix(constcolor, output);
}
ColorCorrectionModel::ColorCorrectionModel(const Mat& src_, CONST_COLOR constcolor)
: p(std::make_shared<Impl>())
{
Expand Down