I've added explicit public modifiers to the remaining class members (fields, constructors, and methods) in TypeScript files within the src/CrystalQuartz.Application.Client2/src/dialogs directory.

This completes the effort to improve code clarity and explicitness in this directory.

This commit includes changes for:
- `src/CrystalQuartz.Application.Client2/src/dialogs/dialog-view-base.tsx`
- `src/CrystalQuartz.Application.Client2/src/dialogs/dialog-view-model.ts`
- `src/CrystalQuartz.Application.Client2/src/dialogs/job-details/job-details-view-model.ts`
- `src/CrystalQuartz.Application.Client2/src/dialogs/schedule-job/schedule-job-view-model.ts`
- `src/CrystalQuartz.Application.Client2/src/dialogs/schedule-job/steps/group-configuration-step.ts`
- `src/CrystalQuartz.Application.Client2/src/dialogs/schedule-job/steps/job-configuration-step.ts`
- `src/CrystalQuartz.Application.Client2/src/dialogs/schedule-job/steps/trigger-configuration-step.ts`
- `src/CrystalQuartz.Application.Client2/src/dialogs/scheduler-details/scheduler-details-view-model.ts`
- `src/CrystalQuartz.Application.Client2/src/dialogs/trigger-details/trigger-details-view-model.ts`

Previously completed steps for this directory are in commits for branches `feature/public-dialog-modifiers-partial` and `feature/public-dialog-modifiers-partial-2`.

Author: google-labs-jules[bot]

src/CrystalQuartz.Application.Client2/src/dialogs/schedule-job/steps/job-configuration-step.ts

@@ -16,18 +16,18 @@ export class JobType {
 }
 
 export class JobConfigurationStep /*extends Owner*/ implements ConfigurationStep {
-  code = 'job';
-  navigationLabel = 'Configure Job';
-
-  jobType = new BidirectionalValue<string | null>((_) => true, null);
-  jobTypeOptions = new ObservableList<SelectOption>();
-  existingJobs = new ObservableList<SelectOption>();
-  selectedJob = new BidirectionalValue<string | null>((_) => true, null);
-  newJobName = new BidirectionalValue<string>((_) => true, '');
-  newJobClass = new BidirectionalValue<string>((_) => true, '');
-  allowedJobTypes = new ObservableList<SelectOption>();
-
-  validators = new Validators();
+  public code = 'job';
+  public navigationLabel = 'Configure Job';
+
+  public jobType = new BidirectionalValue<string | null>((_) => true, null);
+  public jobTypeOptions = new ObservableList<SelectOption>();
+  public existingJobs = new ObservableList<SelectOption>();
+  public selectedJob = new BidirectionalValue<string | null>((_) => true, null);
+  public newJobName = new BidirectionalValue<string>((_) => true, '');
+  public newJobClass = new BidirectionalValue<string>((_) => true, '');
+  public allowedJobTypes = new ObservableList<SelectOption>();
+
+  public validators = new Validators();
   public readonly newJobClassValidator = this.validators.register(
     {
       source: this.newJobClass,
@@ -43,7 +43,7 @@ export class JobConfigurationStep /*extends Owner*/ implements ConfigurationStep
     ValidatorsFactory.required('Please select a Job')
   );
 
-  constructor(
+  public constructor(
     private schedulerExplorer: SchedulerExplorer,
     allowedJobTypes: TypeInfo[]
   ) {
@@ -59,7 +59,7 @@ export class JobConfigurationStep /*extends Owner*/ implements ConfigurationStep
     // this.own(this.validators);
   }
 
-  onEnter(data: ConfigurationStepData): ConfigurationStepData {
+  public onEnter(data: ConfigurationStepData): ConfigurationStepData {
     const selectedJobGroupName = data.groupName || 'Default';
 
     const jobGroup = this.schedulerExplorer
@@ -109,15 +109,15 @@ export class JobConfigurationStep /*extends Owner*/ implements ConfigurationStep
     return data;
   }
 
-  onLeave(data: ConfigurationStepData): ConfigurationStepData {
+  public onLeave(data: ConfigurationStepData): ConfigurationStepData {
     return {
       groupName: data.groupName,
       jobName: this.getJobName(),
       jobClass: this.getJobClass(),
     };
   }
 
-  getJobName(): string | null {
+  public getJobName(): string | null {
     const jobType = this.jobType.getValue();
 
     switch (jobType) {
@@ -133,7 +133,7 @@ export class JobConfigurationStep /*extends Owner*/ implements ConfigurationStep
     }
   }
 
-  getJobClass(): string | null {
+  public getJobClass(): string | null {
     const jobType = this.jobType.getValue();
 
     switch (jobType) {

src/CrystalQuartz.Application.Client2/src/dialogs/schedule-job/steps/trigger-configuration-step.ts

@@ -29,26 +29,26 @@ export interface TriggerStepData {
 export class TriggerConfigurationStep implements ConfigurationStep, Disposable {
   private _owner = new Owner();
 
-  code = 'trigger';
-  navigationLabel = '';
+  public code = 'trigger';
+  public navigationLabel = '';
 
-  triggerName = new BidirectionalValue<string>((_) => true, '');
-  triggerType = new BidirectionalValue<string>((_) => true, 'Simple');
-  cronExpression = new BidirectionalValue<string>((_) => true, '');
-  repeatForever = new BidirectionalValue<boolean>((_) => true, false);
-  repeatCount = new BidirectionalValue<string>((_) => true, '');
-  repeatInterval = new BidirectionalValue<string>((_) => true, '');
-  repeatIntervalType = new BidirectionalValue<string>((_) => true, 'Milliseconds');
+  public triggerName = new BidirectionalValue<string>((_) => true, '');
+  public triggerType = new BidirectionalValue<string>((_) => true, 'Simple');
+  public cronExpression = new BidirectionalValue<string>((_) => true, '');
+  public repeatForever = new BidirectionalValue<boolean>((_) => true, false);
+  public repeatCount = new BidirectionalValue<string>((_) => true, '');
+  public repeatInterval = new BidirectionalValue<string>((_) => true, '');
+  public repeatIntervalType = new BidirectionalValue<string>((_) => true, 'Milliseconds');
 
-  jobDataMap = new ObservableList<JobDataMapItem>();
+  public jobDataMap = new ObservableList<JobDataMapItem>();
 
-  newJobDataKey = new BidirectionalValue<string>((_) => true, '');
-  canAddJobDataKey: Listenable<boolean>;
+  public newJobDataKey = new BidirectionalValue<string>((_) => true, '');
+  public canAddJobDataKey: Listenable<boolean>;
 
   private _isSimpleTrigger = map(this.triggerType, (x) => x === 'Simple');
 
-  validators = new Validators();
-  repeatCountValidator = this.validators.register(
+  public validators = new Validators();
+  public repeatCountValidator = this.validators.register(
     {
       source: this.repeatCount,
       condition: combine(
@@ -60,15 +60,15 @@ export class TriggerConfigurationStep implements ConfigurationStep, Disposable {
     ValidatorsFactory.required('Please enter repeat count'),
     ValidatorsFactory.isInteger('Please enter an integer number')
   );
-  repeatIntervalValidator = this.validators.register(
+  public repeatIntervalValidator = this.validators.register(
     {
       source: this.repeatInterval,
       condition: this._isSimpleTrigger,
     },
     ValidatorsFactory.required('Please enter repeat interval'),
     ValidatorsFactory.isInteger('Please enter an integer number')
   );
-  cronExpressionValidator = this.validators.register(
+  public cronExpressionValidator = this.validators.register(
     {
       source: this.cronExpression,
       condition: map(this.triggerType, (x) => x === 'Cron'),
@@ -79,7 +79,7 @@ export class TriggerConfigurationStep implements ConfigurationStep, Disposable {
   private _inputTypes: InputType[] | null = null;
   private _inputTypesVariants: { [inputTypeCode: string]: InputTypeVariant[] } = {};
 
-  constructor(private commandService: CommandService) {
+  public constructor(private commandService: CommandService) {
     const newJobDataKeyValidationModel = this.validators.register(
       {
         source: this.newJobDataKey,
@@ -103,7 +103,7 @@ export class TriggerConfigurationStep implements ConfigurationStep, Disposable {
     this._owner.own(this.validators);
   }
 
-  addJobDataMapItem() {
+  public addJobDataMapItem() {
     const payload = (inputTypes: InputType[]) => {
       const jobDataMapItem = new JobDataMapItem(
         this.newJobDataKey.getValue(),
@@ -133,7 +133,7 @@ export class TriggerConfigurationStep implements ConfigurationStep, Disposable {
     }
   }
 
-  composeTriggerStepData(): TriggerStepData {
+  public composeTriggerStepData(): TriggerStepData {
     const result: TriggerStepData = {
       name: NULL_IF_EMPTY(this.triggerName.getValue()),
       triggerType: this.triggerType.getValue(),
@@ -163,7 +163,7 @@ export class TriggerConfigurationStep implements ConfigurationStep, Disposable {
     return result;
   }
 
-  displayValidationErrors(jobDataMapErrors: { [key: string]: string }) {
+  public displayValidationErrors(jobDataMapErrors: { [key: string]: string }) {
     Object.getOwnPropertyNames(jobDataMapErrors).forEach((key) => {
       const value = jobDataMapErrors[key];
 
@@ -175,7 +175,7 @@ export class TriggerConfigurationStep implements ConfigurationStep, Disposable {
     });
   }
 
-  dispose() {
+  public dispose() {
     this._owner.dispose();
   }
 

src/CrystalQuartz.Application.Client2/src/dialogs/scheduler-details/scheduler-details-view-model.ts

@@ -6,16 +6,16 @@ import { Property, PropertyType } from '../common/property';
 import { DialogViewModel } from '../dialog-view-model';
 
 export default class SchedulerDetailsViewModel extends DialogViewModel<any> {
-  summary = new ObservableList<Property>();
-  status = new ObservableList<Property>();
-  jobStore = new ObservableList<Property>();
-  threadPool = new ObservableList<Property>();
+  public summary = new ObservableList<Property>();
+  public status = new ObservableList<Property>();
+  public jobStore = new ObservableList<Property>();
+  public threadPool = new ObservableList<Property>();
 
-  constructor(private commandService: CommandService) {
+  public constructor(private commandService: CommandService) {
     super();
   }
 
-  loadDetails() {
+  public loadDetails() {
     this.commandService
       .executeCommand<SchedulerDetails>(new GetSchedulerDetailsCommand())
       .then((response) => {

src/CrystalQuartz.Application.Client2/src/dialogs/trigger-details/trigger-details-view-model.ts

@@ -12,12 +12,12 @@ import { Property, PropertyType } from '../common/property';
 import { DialogViewModel } from '../dialog-view-model';
 
 export class TriggerDetailsViewModel extends DialogViewModel<any> {
-  summary = new ObservableList<Property>();
-  identity = new ObservableList<Property>();
-  schedule = new ObservableList<Property>();
-  jobDataMap = new ObservableValue<PropertyValue | null>(null);
+  public summary = new ObservableList<Property>();
+  public identity = new ObservableList<Property>();
+  public schedule = new ObservableList<Property>();
+  public jobDataMap = new ObservableValue<PropertyValue | null>(null);
 
-  constructor(
+  public constructor(
     private trigger: Trigger,
     private commandService: CommandService
   ) {
@@ -26,7 +26,7 @@ export class TriggerDetailsViewModel extends DialogViewModel<any> {
     this.state.setValue('unknown');
   }
 
-  loadDetails() {
+  public loadDetails() {
     this.commandService
       .executeCommand<TriggerDetails>(
         new GetTriggerDetailsCommand(this.trigger.GroupName, this.trigger.Name),