Merge new frontend UI (not connected yet) to master#116
Merged
guryanovev merged 58 commits intomasterfrom Jul 1, 2025
Merged
Conversation
This change adds explicit `public` modifiers to class members (fields, constructors, and methods) in TypeScript files within the `src/CrystalQuartz.Application.Client2/src/commands` directory. This is done to improve code clarity and explicitness, without changing any functionality.
…` modifiers to dialog members: This change adds explicit `public` modifiers to class members (fields, constructors, and methods) in TypeScript files within the `src/CrystalQuartz.Application.Client2/src/dialogs` directory. This is part of a larger effort to improve your code's clarity and explicitness. So far, I've: - Modified `src/CrystalQuartz.Application.Client2/src/dialogs/activity-details/activity-details-view-model.ts` - Modified `src/CrystalQuartz.Application.Client2/src/dialogs/common/job-data-map.ts` - Modified `src/CrystalQuartz.Application.Client2/src/dialogs/common/property.ts` - Modified `src/CrystalQuartz.Application.Client2/src/dialogs/common/validation/validator-view-model.ts` - Modified `src/CrystalQuartz.Application.Client2/src/dialogs/common/validation/validators-factory.ts` - Modified `src/CrystalQuartz.Application.Client2/src/dialogs/common/validation/validators.ts` - Modified `src/CrystalQuartz.Application.Client2/src/dialogs/common/value-formatting.ts` - Modified `src/CrystalQuartz.Application.Client2/src/dialogs/dialog-manager.ts`
Update build.yaml
This change adds explicit `public` modifiers to class members (fields, constructors, methods, getters, and setters) in TypeScript files within the `src/CrystalQuartz.Application.Client2/src/global` directory. This is done to improve code clarity and explicitness, without changing any functionality.
This change continues adding explicit `public` modifiers to class members (fields, constructors, and methods) in TypeScript files within the `src/CrystalQuartz.Application.Client2/src/dialogs` directory. This is part of a larger effort to improve code clarity and explicitness. Completed steps in this phase: - Modified `src/CrystalQuartz.Application.Client2/src/dialogs/dialog-view-base.tsx` - Modified `src/CrystalQuartz.Application.Client2/src/dialogs/dialog-view-model.ts` - Modified `src/CrystalQuartz.Application.Client2/src/dialogs/job-details/job-details-view-model.ts` - Modified `src/CrystalQuartz.Application.Client2/src/dialogs/schedule-job/schedule-job-view-model.ts` - Modified `src/CrystalQuartz.Application.Client2/src/dialogs/schedule-job/steps/group-configuration-step.ts` Previously completed steps for this directory are in the commit for branch `feature/public-dialog-modifiers-partial`.
… (fields, constructors, and methods) in TypeScript files within the `src/CrystalQuartz.Application.Client2/src/dialogs` directory. This completes the effort to improve code clarity and explicitness in this directory. This commit includes changes for: - `src/CrystalQuartz.Application.Client2/src/dialogs/dialog-view-base.tsx` - `src/CrystalQuartz.Application.Client2/src/dialogs/dialog-view-model.ts` - `src/CrystalQuartz.Application.Client2/src/dialogs/job-details/job-details-view-model.ts` - `src/CrystalQuartz.Application.Client2/src/dialogs/schedule-job/schedule-job-view-model.ts` - `src/CrystalQuartz.Application.Client2/src/dialogs/schedule-job/steps/group-configuration-step.ts` - `src/CrystalQuartz.Application.Client2/src/dialogs/schedule-job/steps/job-configuration-step.ts` - `src/CrystalQuartz.Application.Client2/src/dialogs/schedule-job/steps/trigger-configuration-step.ts` - `src/CrystalQuartz.Application.Client2/src/dialogs/scheduler-details/scheduler-details-view-model.ts` - `src/CrystalQuartz.Application.Client2/src/dialogs/trigger-details/trigger-details-view-model.ts` Previously completed steps for this directory are in commits for branches `feature/public-dialog-modifiers-partial` and `feature/public-dialog-modifiers-partial-2`.
…tructors, and methods) in TypeScript files within the `src/CrystalQuartz.Application.Client2/src` directory (excluding sub-directories which I handled previously). This is part of an ongoing effort to improve code clarity and explicitness throughout your application. I modified the following files: - `src/CrystalQuartz.Application.Client2/src/application-model.ts` - `src/CrystalQuartz.Application.Client2/src/command-action.ts` - `src/CrystalQuartz.Application.Client2/src/data-loader.ts` - `src/CrystalQuartz.Application.Client2/src/global-activities-synchronizer.ts` - `src/CrystalQuartz.Application.Client2/src/scheduler-state-service.ts`
Extracted classes, interfaces, enums, and type aliases from src/CrystalQuartz.Application.Client2/src/api/index.ts into individual files within the same directory. Updated the main index.ts to re-export all models from their new locations, preserving the external API of the module.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.