Fix for windows users with space in tsc path#62
Open
foohines wants to merge 2 commits intogustavopch:masterfrom
Open
Fix for windows users with space in tsc path#62foohines wants to merge 2 commits intogustavopch:masterfrom
foohines wants to merge 2 commits intogustavopch:masterfrom
Conversation
|
Shouldn't setting |
Contributor
Author
|
I don't think so. I tested your fork and my own with just |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes the issue #60 which occurs when:
tsc.cmdincludes a space e.gC:\Users\foohines\code\dir with space\node_modules\.bin\tsc.cmdThis fix works by:
tscPathin double quotes if it contains a space (passed as spawnSync's first argument)projectArgin double quotes if it contains a space (passed in spawnSync's second argument){ shell: true }option to spawnSync for windows users onlyMore context can be found in the node documentation on how to correctly spawn windows .cmd files