Switch Reflex project to unity 6000.0.67f1#133
Open
octia wants to merge 3 commits intogustavopsantos:mainfrom
Open
Switch Reflex project to unity 6000.0.67f1#133octia wants to merge 3 commits intogustavopsantos:mainfrom
octia wants to merge 3 commits intogustavopsantos:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Current project (in unity 2021) doesn't open for me, and I need to work in unity 6 anyway when contributing. I've moved the project to the newest unity 6.0 LTS.
All changes were made either automatically by unity during the switch, or by me updating all the packages used by the project. No code changes are present, as none were needed.
Worth noting
In package.json I switched the "unity" property (which indicates the minimal unity version the package is guaranteed to work with) to unity 6000.0, since while it doesn't prevent anyone from installing reflex on older versions, it indicates that we promise nothing for non-lts versions of unity. Depending on the support goals it might be worth reverting the commit, or putting an older version there.
How Has This Been Tested?
Edit mode and play mode tests all pass. I see no errors anywhere, although it's probably worth to double check before merging. I've had issues on the 2021 version on some machines while I didn't have them on others - something similar could happen on unity 6
Checklist: