Skip to content

Commit 794877c

Browse files
committed
bump major ver & forbid loading addons if major ver is mismatched in deps
for upcoming changes this will be better, than catching bugs and crashes around
1 parent 8a50976 commit 794877c

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed

loader_core/gw2al_api_addon_registry.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -168,7 +168,7 @@ gw2al_api_ret gw2al_core__load_addon(const wchar_t * name)
168168
depDsc = gw2al_core__query_addon(gw2al_core__hash_name((wchar_t*)laddon.desc->dependList[i].name));
169169
}
170170

171-
if ((depDsc->majorVer < laddon.desc->dependList[i].majorVer) || (depDsc->minorVer < laddon.desc->dependList[i].minorVer))
171+
if ((depDsc->majorVer != laddon.desc->dependList[i].majorVer) || (depDsc->minorVer < laddon.desc->dependList[i].minorVer))
172172
{
173173
LOG_WARNING(L"core", L"Addon \"%s\" is not loaded due to wrong dependency version \"%s\". Require v%u.%u(r%u) but have v%u.%u(r%u)", name, laddon.desc->dependList[i].name,
174174
laddon.desc->dependList[i].majorVer, laddon.desc->dependList[i].minorVer, laddon.desc->dependList[i].revision,

loader_core/version.h

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
#pragma once
22

3-
#define LOADER_CORE_VER_MAJOR 0
4-
#define LOADER_CORE_VER_MINOR 4
3+
#define LOADER_CORE_VER_MAJOR 1
4+
#define LOADER_CORE_VER_MINOR 0
55
#define LOADER_CORE_VER_REV BUILD_VERSION_REV
66
#define LOADER_CORE_VER_NAME BUILD_VERSION_NAME

0 commit comments

Comments
 (0)