A bug fixed by correcting missing parentheses#3
Conversation
MaxMelching
left a comment
There was a problem hiding this comment.
This certainly fixes the bug, but couldn't we also just remove the ( right before dict_waveform_modification? Then we do not need the closing parentheses in lines 102, 246 (or the ones that are added, does not matter). And I do not see any reason why Python would want them there
|
@sum33it Please could you implement @MaxMelching 's suggestion here. Having additional, unnecessary extra parentheses impacts on code readability. PyCBC aims to use |
|
Hi @spxiwh Thanks for pointing this out. I will do it in next PR. |
|
@spxiwh I like the |
|
We just use the default settings ... Though having a properly defined config within the repository ... and actually running it on a bunch of older code would be good! This is described here (https://github.com/gwastro/pycbc/wiki/How-to-satisfy-CodeClimate) ... I agree that this is not an ideal place for this to live! |
This PR fixes a bug in the code. The parenthesis were missing at couple of places.