Skip to content

Move to igwn_ligolw#69

Merged
spxiwh merged 31 commits intogwastro:masterfrom
spxiwh:igwn_ligolw
Jul 3, 2025
Merged

Move to igwn_ligolw#69
spxiwh merged 31 commits intogwastro:masterfrom
spxiwh:igwn_ligolw

Conversation

@spxiwh
Copy link
Collaborator

@spxiwh spxiwh commented Jul 2, 2025

This is @GarethCabournDavies 's patch ... but hopefully it now works.

I also resolved deprecation warnings and removed mention of ligolw from debian stuff (I'm not too concerned about the debain stuff as long as it doesn't result in trying to install the old ligolw).

@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 90.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 54.84%. Comparing base (de73773) to head (76bfa9c).
Report is 9 commits behind head on master.

Files with missing lines Patch % Lines
sbank/psds.py 88.89% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #69      +/-   ##
==========================================
- Coverage   55.36%   54.84%   -0.51%     
==========================================
  Files          10        9       -1     
  Lines        1167     1167              
==========================================
- Hits          646      640       -6     
- Misses        521      527       +6     
Flag Coverage Δ
Linux 54.84% <90.00%> (-0.51%) ⬇️
macOS ?
python3.10 ?
python3.11 ?
python3.8 ?
python3.9 54.84% <90.00%> (-0.57%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@spxiwh
Copy link
Collaborator Author

spxiwh commented Jul 2, 2025

I think I fixed the translation issues, but in trying to persuade this to build using non-ancient versions of lalsuite I'm hitting a failure I don't understand.

@spxiwh
Copy link
Collaborator Author

spxiwh commented Jul 3, 2025

@GarethCabournDavies This should be ready for review now.

@GarethCabournDavies GarethCabournDavies self-requested a review July 3, 2025 12:32
Copy link
Contributor

@GarethCabournDavies GarethCabournDavies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this all looks good. A few comments, but mostly questions rather than anything holding up approval

@spxiwh
Copy link
Collaborator Author

spxiwh commented Jul 3, 2025

Thanks @GarethCabournDavies I think I've resolved the comments now(?)

@GarethCabournDavies
Copy link
Contributor

All resolved 👍

@spxiwh spxiwh merged commit 94088fe into gwastro:master Jul 3, 2025
21 checks passed
@spxiwh spxiwh deleted the igwn_ligolw branch July 3, 2025 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants