Conversation
|
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #69 +/- ##
==========================================
- Coverage 55.36% 54.84% -0.51%
==========================================
Files 10 9 -1
Lines 1167 1167
==========================================
- Hits 646 640 -6
- Misses 521 527 +6
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
I think I fixed the translation issues, but in trying to persuade this to build using non-ancient versions of lalsuite I'm hitting a failure I don't understand. |
|
@GarethCabournDavies This should be ready for review now. |
GarethCabournDavies
left a comment
There was a problem hiding this comment.
I think this all looks good. A few comments, but mostly questions rather than anything holding up approval
|
Thanks @GarethCabournDavies I think I've resolved the comments now(?) |
|
All resolved 👍 |
This is @GarethCabournDavies 's patch ... but hopefully it now works.
I also resolved deprecation warnings and removed mention of ligolw from debian stuff (I'm not too concerned about the debain stuff as long as it doesn't result in trying to install the old ligolw).