Merged
Conversation
Collaborator
Author
|
I need to spend some more time arguing with our testing and CI system, so the test I started for this is also skipped, but I think this should be okay if either of y'all are up for manually testing this with the steps in the PR. |
dolsysmith
approved these changes
Dec 1, 2025
Contributor
dolsysmith
left a comment
There was a problem hiding this comment.
PDF is rendered correctly and viewer behaves as expected.
alepbloyd
added a commit
that referenced
this pull request
Jan 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Description
Adds pdfjs viewer for AcademicDocuments. When an AcademicDocument with a pdf format is deposited and processed, the show page for that work should appear with an embedded PDF viewer by default.
Related Tickets & Documents
QA Instructions, Screenshots, Recordings
Run automated test suite, should see 205 examples, 0 failures, 1 pending.
Manual testing:
admin@example.com, password ispassword)Contrary to how
ArchivalDocuments are processed, these works do not get split into componentDerivedPageworks for IIIF rendering, so you should not have to trigger any jobs in sidekiq and this should run fairly quickly.Added/updated tests?
have not been included
Other notes
On sticking the whole PDFJS directory in /public. There is probably a good way to have PDFJS build with the Docker images, but the example code for PDFJS (https://mozilla.github.io/pdf.js/getting_started/) is based on including the pre-built build in the repository.
This is operating under the general assumption that 'AcademicDocuments' will be PDF files. I have the pdfjs view panel set to conditionally render based on if the representative media is a pdf, so it should be okay to deposit non-pdfs as this work type, but there will not be a viewing panel.