feat:(DS-1367) Update disabled color datapicker#932
Closed
nataliogympass wants to merge 3 commits intomasterfrom
Closed
feat:(DS-1367) Update disabled color datapicker#932nataliogympass wants to merge 3 commits intomasterfrom
nataliogympass wants to merge 3 commits intomasterfrom
Conversation
nataliogympass
requested review from
a team,
flaviafmoraes,
matheus-wh and
wellhub-gsevla
as code owners
Collaborator
There was a problem hiding this comment.
I think this change is right. But I'm wondering if we would need to review past PRs and handle semantics. The latest PR, for example, changed things from backgroundAndDisabled to colors.steady directly. Was that right? Example: https://github.com/gympass/yoga/pull/930/changes?show-viewed-files=true#diff-dcafe1732fcde07b11e67e289de697a2a33e37f0d7124b10aafdc4a4de469938
| }, | ||
| }) => ` | ||
| fill: ${disabled ? colors.text.disabled : colors.text.primary}; | ||
| fill: ${disabled ? colors.steady : colors.text.primary}; |
Collaborator
There was a problem hiding this comment.
Looking at v3theme, colors.text.disabled === colors.steady. Does this component really need refactoring?
| } | ||
| if (disabled) { | ||
| return colors.text.disabled; | ||
| return colors.steady; |
Collaborator
There was a problem hiding this comment.
Looking at v3theme, colors.text.disabled === colors.steady. Does this component really need refactoring?
|
❌ The last analysis has failed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description 📄
Data picker color update when disabled.
Platforms 📲
Type of change 🔍
How Has This Been Tested? 🧪
[Enter the tips to test this PR]
Checklist: 🔍
Screenshots 📸
[Upload your screenshots here]