fix: remove spurious checkbox from skills selector in custom fighters#1544
Open
tgvashworth wants to merge 1 commit intomainfrom
Open
fix: remove spurious checkbox from skills selector in custom fighters#1544tgvashworth wants to merge 1 commit intomainfrom
tgvashworth wants to merge 1 commit intomainfrom
Conversation
The group_select() helper detected multi-select widgets by checking
whether the widget class name ended with "Multiple". The compact
checkbox widget (BsCheckboxSelectMultipleCompact) ends with "Compact",
so it was treated as a single-select and got the empty placeholder
option ("", "---------") prepended — which rendered as an errant
checkbox at the top of the skills list.
Replace the fragile class-name string check with Django's
allow_multiple_selected attribute, which reliably identifies
multi-select widgets regardless of their class naming.
Closes #1543
Co-authored-by: Tom Ashworth <tgvashworth@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes an issue in group_select() where some multi-select widgets were incorrectly treated as single-select, causing an empty placeholder option to be prepended and rendered as a spurious checkbox in the custom fighter skills selector (Fixes #1543).
Changes:
- Replace the widget “multiple” detection logic from a class-name suffix check (
...endswith("Multiple")) to Django’sallow_multiple_selectedattribute. - Add a regression test covering
BsCheckboxSelectMultipleCompactto ensure no empty placeholder option is prepended for multi-select widgets.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
gyrinx/forms.py |
Uses allow_multiple_selected to reliably determine whether to prepend the empty option in group_select(). |
gyrinx/tests/test_forms.py |
Adds a regression test ensuring compact checkbox multi-select widgets do not receive an empty placeholder choice. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1543
The
group_select()helper detected multi-select widgets by checking whether the widget class name ended with "Multiple". The compact checkbox widget (BsCheckboxSelectMultipleCompact) ends with "Compact", so it was treated as a single-select and got the empty placeholder option prepended — which rendered as an errant checkbox.Replaces the fragile class-name string check with Django’s
allow_multiple_selectedattribute.Generated with Claude Code