Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions src/pook/interceptors/aiohttp.py
Original file line number Diff line number Diff line change
Expand Up @@ -95,11 +95,11 @@ async def _on_request(
if not kw.get("params"):
req.url = str(full_url)
else:
req.url = (
str(full_url)
+ "?"
+ urlencode([(x, y) for x, y in kw["params"].items()])
)
# Transform params as a list of tuple
params = kw["params"]
if isinstance(params, dict):
params = [(x, y) for x, y in kw["params"].items()]
req.url = str(full_url) + "?" + urlencode(params)

# If a json payload is provided, serialize it for JSONMatcher support
if json_body := kw.get("json"):
Expand Down
24 changes: 24 additions & 0 deletions tests/unit/interceptors/aiohttp_test.py
Original file line number Diff line number Diff line change
Expand Up @@ -109,3 +109,27 @@ async def test_client_headers_both_session_and_request(local_responder):
)
assert res.status == 200
assert await res.read() == b"hello from pook"


@pytest.mark.asyncio
async def test_client_params_dict(local_responder):
""" "Params using dict"""
pook.get(local_responder + "/status/404").reply(200)
async with aiohttp.ClientSession(base_url=local_responder.url) as session:
res = await session.get("/status/404", params={"key": "value"})
assert res.status == 200
assert res.url.query.get("key") == "value"
assert res.url.query.getall("key") == ["value"]


@pytest.mark.asyncio
async def test_client_params_tuple_of_tuple(local_responder):
""" "Params using tuple of tuple for multiple parameter key usage"""
pook.get(local_responder + "/status/404").reply(200)
async with aiohttp.ClientSession(base_url=local_responder.url) as session:
res = await session.get(
"/status/404", params=(("key", "value"), ("key", "another-value"))
)
assert res.status == 200
assert res.url.query.get("key") == "value"
assert res.url.query.getall("key") == ["value", "another-value"]