Properly decode the aiohttp.ClientRequest body#177
Open
hovsater wants to merge 1 commit intoh2non:masterfrom
Open
Properly decode the aiohttp.ClientRequest body#177hovsater wants to merge 1 commit intoh2non:masterfrom
aiohttp.ClientRequest body#177hovsater wants to merge 1 commit intoh2non:masterfrom
Conversation
The body of `aiohttp.ClientRequest` is a `aiohttp.payload.Payload` and thus it won't compare correctly when used by the `BodyMatcher`. `aiohttp.payload.Payload` provides a `decode` method we can use to turn the underlying payload into a string representation suitable for matching.
Author
|
@xrmx would you mind looking at this? 🙂 |
Contributor
|
@hovsater I'm not a maintainer, not sure why are you pinging me :) |
Author
|
@xrmx 🙈 I'm sorry, I mistakenly took you for a maintainer but I see now you're a contributor. My bad and sorry for the noise. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The body of
aiohttp.ClientRequestis aaiohttp.payload.Payloadand thus it won't compare correctly when used by theBodyMatcher. This will result in a cryptic error message like so:The
aiohttp.payload.PayloadABC provides adecodemethod we can use to turn the underlying payload into a string representation suitable for matching.PR Checklist