fix: aiohttp interceptor compatibility with aiohttp 4.x#179
Open
ChaitanyaKhoje wants to merge 1 commit intoh2non:masterfrom
Open
fix: aiohttp interceptor compatibility with aiohttp 4.x#179ChaitanyaKhoje wants to merge 1 commit intoh2non:masterfrom
ChaitanyaKhoje wants to merge 1 commit intoh2non:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
aiohttp.ClientHandlerTypewas removed in aiohttp 4.0, causing anAttributeErrorwhen pook's aiohttp interceptor is loaded with aiohttp 4.x installed.Affected line:
src/pook/interceptors/aiohttp.py— the__call__signature usesaiohttp.ClientHandlerTypeas a type annotation.Fix
Replace
aiohttp.ClientHandlerTypewithCallablefromtyping, which is the correct approach for aiohttp 4.x and remains backwards compatible.Reproduction
Pin
aiohttp>=4and run any test suite that imports pook's aiohttp interceptor — test collection will fail.Workaround used downstream: pin
aiohttp<4