Conversation
vaex/groupby-vaex.py
Outdated
| return x.groupby(['id1','id2','id3','id4','id5','id6']).agg({'v3':'sum', 'v1':'count'}) | ||
|
|
||
| # Generic benchmark function - to improve code readability | ||
| def benchmark(func, question, chk_sum_cols): |
There was a problem hiding this comment.
One of the goals was to make scripts be matching between languages/solutions. Using helpers makes it more blurry and less reproducible interactively line by line. It has been proposed already at least twice before, in python datatable and Julia DF. I see no way to satisfy those goals and keep using helpers. Helpers would have to be the same in each language, and that requires investigation to compare overhead they would make in each language. Therefore I would suggest to keep the structure quite the same as the other solutions are written now.
Note that I am not longer maintaining the project as I am no longer an employee of h2o.
There was a problem hiding this comment.
Thank you @jangorecki, we will do it.
There was a problem hiding this comment.
Hey @jangorecki
We refactored the code, so now it should be the exact same style as the rest of the repo.
I appreciate that you are not longer employed by h2o and not actively maintaining the project, but can you possibly point us to who should we contact regarding any further reviews, actions etc.
Thank you, and thank you for putting this all together.
There was a problem hiding this comment.
Not sure but @srini-x had some recent activity in this repo, so possibly he could help on that. Otherwise contacting h2o support or twitter should work.
|
|
||
| ver = vaex.__version__['vaex-core'] | ||
| git = 'alpha' | ||
| git = '-' |
There was a problem hiding this comment.
This should stay as NA or "" if git hash is not available
There was a problem hiding this comment.
Ah I think i saw it for some of the other libraries.. but I will fix it !
Thank you!
3 participants
Hi,
Hope we did this correctly, if there is anything you need, let us know. cc @JovanVeljanoski
Regards,
Maarten
Closes #180