fix polars groupby script to polars==latest#244
Open
ritchie46 wants to merge 6 commits intoh2oai:masterfrom
Open
fix polars groupby script to polars==latest#244ritchie46 wants to merge 6 commits intoh2oai:masterfrom
ritchie46 wants to merge 6 commits intoh2oai:masterfrom
Conversation
|
I found the same issue under polars == 0.13.25. And I used the same code in this branch to make the bench test running correctly. |
ritchie46
changed the title
cosmojg
approved these changes
May 15, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Polars
0.13.0had some breaking changes. This PR fixes the groupby script accordingly.Edit: I will keep this on par with the
db-benchmark ciwe run on latestmasterbranch. This will ensure latest polars runs as expected.