Conversation
InMemoryDatasets.jl is a new package for data manipulation in Julia.
jangorecki
left a comment
jangorecki
left a comment
There was a problem hiding this comment.
PR looks very good. Just to let you know that I am no longer maintaining the project (although I am happy to provide the feedback) and the best way to have your PR merged and run is, I believe, contacting h2o.ai support. Project is inactive for a longer while but I haven't heard anything about it to be abandoned. Looking forward to see benchmark results.
| @@ -0,0 +1,58 @@ | |||
| using Printf; # sprintf macro to print in non-scientific format | |||
There was a problem hiding this comment.
AFAIU this file could be shared between juliadf and juliads. As we do for pyton and R tools.
There was a problem hiding this comment.
IMD uses DLMReader for writing the log file, however, DataFrames.jl uses CSV. So one possible way to combine these is to have different write_log functions in the same file.
| using DLMReader; | ||
| using PooledArrays | ||
|
|
||
| IMD.warmup() |
There was a problem hiding this comment.
Would be nice to have a comment what this warm up actually do
|
Thanks for your feedback. I have made some changes based on your comments. |
2 participants
InMemoryDatasets.jl is a new package for data manipulation in Julia. Please let me know if anything is wrong.