GH-16718 remove support for python 3.6 in CI#16721
GH-16718 remove support for python 3.6 in CI#16721valenad1 wants to merge 1 commit intorel-3.46.0from
Conversation
valenad1
force-pushed
the
valenad-GH-16718-remove-support-for-python-3-6-docker
branch
2 times, most recently
from
9827920 to
54e62e5
Compare
tomasfryda
left a comment
tomasfryda
left a comment
There was a problem hiding this comment.
Also I think hadoop images use python 3.6:
File: ./hadoop/hdp/Dockerfile
9 22 ARG PYTHON_VERSIONS='3.6'
File: ./hadoop/cdh/Dockerfile
19 22 ARG PYTHON_VERSIONS='3.6'
I am not sure if we plan support hadoop in future but I would either first remove hadoop support and delete these files or ensure we're able to build these images without python 3.6.
|
|
||
| echo "###### Installing pip for Python ${python_version} ######" | ||
| if [[ ${major} == "2" ]] || [[ ${python_version} == "3.5" ]] || [[ ${python_version} == "3.6" ]] || [[ ${python_version} == "3.7" ]] | ||
| if [[ ${major} == "2" ]] || [[ ${python_version} == "3.5" ]] || [[ ${python_version} == "3.7" ]] |
There was a problem hiding this comment.
I think I modify this in my PR since you have to use this method to get pip for 3.8 as well now. I'd be in favor of removing this change so there is no unnecessary conflict. Also I don't understand the reason of removing support for 3.6 but not 3.5 and 2.x.
There was a problem hiding this comment.
Good point, if you already cover it in your PR, then I can fully skip it.
Hadoop support is still open question. Nevertheless, we were not able to build those images in current setup. HDP support is dropped already.. CDP is not working. Those images need to be done from scratch tohether with dockerfiles. |
|
Did you try to build all the images? I didn't see any recent build of the docker images that wouldn't be mine so I am wondering if you tested it somehow. |
No, I am not planning to do it at all for 3.6 removal. Hadoop is out of scope, and regular images depends on your work, if you can fit this change in and rebuild it together with new R images and nothing breaks in 3.7+ we have a win. If not, then I wouldn't do it at all for python 3.6 removal, because I will run into it with Python 3.12 because the way how its implemented doesn't assure python packed versions and IMHO its pointless to do it for 3.6 removal. |
|
That's why its in different PR, we could
but
|
- Remove python-3.6-jdk-* build targets from docker/Makefile - Remove Python 3.6 special build-from-source handling in install_python_version - Update pip installation conditional to exclude Python 3.6 - Update test-requirements.txt
valenad1
force-pushed
the
valenad-GH-16718-remove-support-for-python-3-6-docker
branch
from
54e62e5 to
2e2ebbe
Compare
2 participants
#16718