Open
Conversation
|
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes h2o.shap_summary_plot() failing when the input data includes a predictor column named id (GH-16758), by avoiding stats::reshape()’s default/generated id column name collision.
Changes:
- Add an internal helper to generate a guaranteed-non-colliding column name.
- Update
h2o.shap_summary_plot()to pass a safeidvarintostats::reshape()calls. - Add regression tests covering both numeric and categorical
idpredictors.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
h2o-r/h2o-package/R/explain.R |
Ensures stats::reshape() uses a non-colliding idvar when reshaping contributions and feature values. |
h2o-r/tests/testdir_misc/explain/runit_shap_summary_plot_id_column.R |
Adds regression coverage to ensure SHAP summary plotting succeeds when a predictor is named id (numeric and categorical). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



#16758