[BREAKING] Refactor config to use MYNEWT macros. #1004
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
h2zero
force-pushed
the
refactor-config
branch
2 times, most recently
from
c53be60 to
49c78ef
Compare
h2zero
force-pushed
the
refactor-config
branch
12 times, most recently
from
79ed35a to
cddf7e3
Compare
h2zero
force-pushed
the
refactor-config
branch
from
cddf7e3 to
554ce4d
Compare
h2zero
changed the title
h2zero
force-pushed
the
refactor-config
branch
6 times, most recently
from
b1dbeec to
2503589
Compare
h2zero
force-pushed
the
refactor-config
branch
6 times, most recently
from
41a4758 to
221849b
Compare
This replaces the previously prefixed CONFIG_BT_X config macros with the underlying MYNEWT_VAL_X config macros that they affected. This will prevent any redefinition issues caused by the ESP Arduino core enabling nimble and ensures that the config values are set correctly.
h2zero
force-pushed
the
refactor-config
branch
from
221849b to
4a601d9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This replaces the previously prefixed
CONFIG_BT_Xconfig macros with the underlyingMYNEWT_VAL_Xconfig macros that they affected. This will prevent any redefinition issues caused by the ESP Arduino core enabling nimble and ensures that the config values are set correctly.Fixes #1014