[BREAKING] Refactor NimBLEDevice #738
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
h2zero
force-pushed
the
refactor-nimbledevice
branch
5 times, most recently
from
cd3534e to
aee31fb
Compare
* General code cleanup * `NimBLEDevice::getInitialized` renamed to `NimBLEDevice::isInitialized`. * `NimBLEDevice::setPower` no longer takes the `esp_power_level_t` and `esp_ble_power_type_t`, instead only an integer value in dbm units is accepted. * `NimBLEDevice::setPower` now returns a bool value, true = success. * `NimBLEDevice::setMTU` now returns a bool value, true = success. * `NimBLEDevice::injectConfirmPIN` renamed to `NimBLEDevice::injectConfirmPasskey` to use Bluetooth naming. * Fixes crash if `NimBLEDevice::deinit` is called when the stack has not been initialized. * Reverts 2db4756 as it would cause a crash when the NimBLEServer instance has a connection. * `NimBLEDevice::getAddress` will now return the address currently in use. * `NimBLEDevice::init` now returns a bool with `true` indicating success. * `NimBLEDevice::deinit` now returns a bool with `true` inidicating success. * `NimBLEDevice::setDeviceName` now returns a bool with `true` indicating success. * `NimBLEDevice::setCustomGapHandler` now returns a bool with `true` indicating success. * `NimBLEDevice::setOwnAddrType` now returns a bool with `true` indicating success. * `NimBLEDevice::setOwnAddrType` will now correctly apply the provided address type for all devices. * `NimBLEDevice::setOwnAddrType` no longer takes a `bool nrpa` parameter.
h2zero
force-pushed
the
refactor-nimbledevice
branch
from
aee31fb to
d836b2c
Compare
Adds a utility to generate random BLE addresses and set the address used.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NimBLEDevice::getInitializedrenamed toNimBLEDevice::isInitialized.NimBLEDevice::setPowerno longer takes theesp_power_level_tandesp_ble_power_type_t, instead only an integer value in dbm units is accepted.NimBLEDevice::setPowernow returns a bool value, true = success.NimBLEDevice::setMTUnow returns a bool value, true = success.NimBLEDevice::injectConfirmPINrenamed toNimBLEDevice::injectConfirmPasskeyto use Bluetooth naming.NimBLEDevice::deinitis called when the stack has not been initialized.NimBLEDevice::getAddresswill now return the address currently in use.NimBLEDevice::initnow returns a bool withtrueindicating success.NimBLEDevice::deinitnow returns a bool withtrueinidicating success.NimBLEDevice::setDeviceNamenow returns a bool withtrueindicating success.NimBLEDevice::setCustomGapHandlernow returns a bool withtrueindicating success.NimBLEDevice::setOwnAddrTypenow returns a bool withtrueindicating success.NimBLEDevice::setOwnAddrTypewill now correctly apply the provided address type for all devices.NimBLEDevice::setOwnAddrTypeno longer takes abool nrpaparameter.Fixes #724