Fix getOutputReport, getInputReport and getFeatureReport: not being able to create more than one report + temporal coupling #812
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Arduino IDE requires this file when developing an Arduino library, but that file must not be included in the release.
h2zero
requested changes
Dec 18, 2024
Done. |
|
Thank you @afpineda ! |
h2zero
pushed a commit
that referenced
this pull request
Dec 22, 2024
…ture report + temporal coupling (#812) * Add ".development" to gitignore Arduino IDE requires this file when developing an Arduino library, but that file must not be included in the release. * Fix get Input/Output/Feature Report
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fix is related to Issue #805 in the
NimBLEHIDDeviceclass.What fixes:
getXXXXXReport()in any order.Fix description:
A new private method is introduced:
locateReportCharacteristicById(): given areportID, it returns the characteristic if already created, nullptr otherwise.getXXXXXReport()tries to locate the characteristic. If found, it is returned "as is". If not found, it is created and returned.Drawbacks:
There is a computational overhead. The user should store/cache the value returned by
getXXXXXReport()instead of repeating the calls. Perhaps we should warn about this in the documentation.