[BREAKING] - Refactor NimBLEUtils #221
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add functions `NimBLEUtils::taskWait` and `NimBLEUtils::taskRelease` to simplify task blocking/messaging. * `NimBLEUtils::buildHexData` replaced with `NimBLEUtils::dataToHexString` * Add missing GAP event strings. * Add missing return code strings. * `NimBLEUtils::dumpGapEvent` function removed. * Event/error code strings optimized.
h2zero
force-pushed
the
refactor-utils
branch
from
90c6e0e to
2aa1896
Compare
thekurtovic
reviewed
Nov 13, 2024
| // Clear the task notification value to ensure we block | ||
| ulTaskNotifyValueClear(cur_task, ULONG_MAX); | ||
| # endif | ||
| ulTaskNotifyTake(pdTRUE, portMAX_DELAY); |
Collaborator
There was a problem hiding this comment.
I've had issues with tasks getting stuck in spots like this*, seemingly due to some race condition. I've been modifying this locally to use a more realistic value of like 20-30s, and that would clear up the problems for me.
Could this be made into a compile-time configurable value?
*ulTaskNotifyTake(pdTRUE, portMAX_DELAY);
Which I assume is equivalent to
NimBLEUtils::taskWait(*m_pTaskData, BLE_NPL_TIME_FOREVER);
Owner
Author
There was a problem hiding this comment.
Yes, this should be something of a config value.
Please open an issue for discussion to address this so we can get more user feedback.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NimBLEUtils::taskWaitandNimBLEUtils::taskReleaseto simplify task blocking/messaging.NimBLEUtils::buildHexDatareplaced withNimBLEUtils::dataToHexStringNimBLEUtils::dumpGapEventfunction removed.