Skip to content

Fix undefined reference to ble_svc_gap_device_name_set when GATT server is disabled #349

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
h2zero merged 2 commits into from
Aug 24, 2025
Merged

Fix undefined reference to ble_svc_gap_device_name_set when GATT server is disabled #349

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6d16a68
Fix undefined reference to ble_svc_gap_device_name_set when GATT serv…
iranl Jul 20, 2025
a6f03fd
Do not affect ESP-IDF <5.5.0
iranl Jul 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/NimBLEDevice.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1290,12 +1290,13 @@ bool NimBLEDevice::injectConfirmPasskey(const NimBLEConnInfo& peerInfo, bool acc
* @param [in] deviceName The name to set.
*/
bool NimBLEDevice::setDeviceName(const std::string& deviceName) {
#if !defined(ESP_IDF_VERSION) || ESP_IDF_VERSION < ESP_IDF_VERSION_VAL(5, 5, 0) || CONFIG_BT_NIMBLE_GAP_SERVICE
int rc = ble_svc_gap_device_name_set(deviceName.c_str());
if (rc != 0) {
NIMBLE_LOGE(LOG_TAG, "Device name not set - too long");
return false;
}

#endif
return true;
} // setDeviceName

Expand Down