fix(cloudflare): send close frame

[jclab-joseph]

Fixes an issue where the readyState is stuck at 2 (closing) when websocket.close is called on the client (browser).

See

• WebSocket API (WebSocketPair) Disconnect Logic Broken cloudflare/workerd#5290
• 🐛 BUG: WebSocket without Durable Object stays in CLOSING state after close cloudflare/workerd#2569

Summary by CodeRabbit

• Bug Fixes
  • Improved server resource cleanup when WebSocket connections are terminated to ensure proper shutdown handling.

_{✏️ Tip: You can customize this high-level summary in your review settings.}

[coderabbitai]

📝 Walkthrough

Walkthrough

The Cloudflare adapter's WebSocket close event handler now explicitly closes the server by calling server.close() when a "close" event is emitted, ensuring proper cleanup after peer connection termination.

Changes

Cohort / File(s)	Summary
WebSocket Close Handler src/adapters/cloudflare.ts	Added explicit server.close() call within the WebSocket "close" event handler to ensure proper server cleanup after peer connections terminate.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~5 minutes

Poem

🐰 A server closed with care so neat,
When peers depart, the exit's sweet,
No lingering threads left in the night,
Clean shutdown happens—all just right!
Cloudflare's path now fully formed,
Where proper cleanup is the norm. ✨

🚥 Pre-merge checks | ✅ 3

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The PR title 'send close frame' is related to the changeset but doesn't capture the main issue being fixed—that WebSocket readyState gets stuck in CLOSING state.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing touches

• 📝 Generate docstrings

---

📜 Recent review details

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 440a088 and 95e911b.

📒 Files selected for processing (1)

• src/adapters/cloudflare.ts

🔇 Additional comments (1)

src/adapters/cloudflare.ts (1)

133-137: Good fix for the Cloudflare close handshake issue.

The explicit server.close() call properly completes the WebSocket close handshake, ensuring the readyState transitions from CLOSING (2) to CLOSED (3). This is necessary in Cloudflare's fallback path when using WebSocketPair.

Consider adding a brief comment explaining this workaround:

Suggested comment

 server.addEventListener("close", (event) => {
   peers.delete(peer);
   hooks.callHook("close", peer, event);
+  // Explicitly close server side to complete close handshake (workerd issue)
   server.close();
 });

Note: The Durable Object close path (handleDurableClose, lines 182-188) doesn't include a similar explicit close call because it uses a different event system where the close event is only invoked after the close handshake is already complete.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[pi0]

Thanks!

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!