Skip to content

chore: update srvx version & usage#178

Merged
pi0 merged 1 commit intoh3js:mainfrom
nperez0111:update-srvx
Jan 19, 2026
Merged

chore: update srvx version & usage#178
pi0 merged 1 commit intoh3js:mainfrom
nperez0111:update-srvx

Conversation

@nperez0111
Copy link
Contributor

@nperez0111 nperez0111 commented Jan 19, 2026

I was getting some type resolution issues because as of srvx@0.8.0 the /types subpath has been removed. The current version of the package attempts to resolve against that & ends up not being able to resolve it since the subpath no longer exists.

Everything still works at runtime though, so I'm submitting this to just bump the dependency, so we can get the type resolution working again.

Thanks for your consideration, I really appreciate all of these packages & am using crossws as the basis for my Y.js sync server, Teleportal!

Summary by CodeRabbit

  • Chores
    • Updated srvx dependency to version 0.10.1 for improved stability and features.
    • Extended PNPM configuration to optimize build dependencies.

✏️ Tip: You can customize this high-level summary in your review settings.

@coderabbitai
Copy link

coderabbitai bot commented Jan 19, 2026

📝 Walkthrough

Walkthrough

The pull request bumps the srvx dependency from ^0.7.1 to ^0.10.1, extends PNPM configuration with onlyBuiltDependencies, and consolidates type imports across server modules from "srvx/types" to "srvx" while removing TypeScript type assertion suppressions.

Changes

Cohort / File(s) Summary
Dependency and Build Configuration
package.json
srvx dependency updated from ^0.7.1 to ^0.10.1; PNPM configuration extended with onlyBuiltDependencies listing @parcel/watcher, esbuild, sharp, and workerd.
Type Import Path Consolidation
src/server/_types.ts, src/server/cloudflare.ts, src/server/default.ts, src/server/deno.ts
Import paths for public Server and ServerPlugin types changed from "srvx/types" to "srvx", reflecting updated module re-export structure.
Type Import Path and TypeScript Assertion Updates
src/server/bun.ts, src/server/node.ts
Import paths updated from "srvx/types" to "srvx"; ts-expect-error suppressions removed from type-checked properties (bun.websocket in bun.ts; originalServe and server.serve in node.ts).

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

🐰 A rabbit's ode to cleaner code:

Srvx hops to version ten,
Types now import from home again,
No more hush-hush, let TypeScript see,
The path is clear, the checks run free! ✨

🚥 Pre-merge checks | ✅ 2 | ❌ 1
❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The PR title accurately describes the primary changes: bumping the srvx version and updating import paths throughout the codebase to resolve type resolution issues.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (1)
package.json (1)

99-106: Consider updating the peerDependency minimum version.

The peerDependency still allows >=0.7.1, but the codebase now imports types from "srvx" instead of "srvx/types". Users on srvx versions <0.8.0 may encounter type resolution failures since those older versions still export types from the /types subpath.

Consider bumping to >=0.8.0 or >=0.10.0 to ensure compatibility.

@codecov
Copy link

codecov bot commented Jan 19, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

Copy link
Member

@pi0 pi0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thnx!

@pi0 pi0 merged commit 05c0f06 into h3js:main Jan 19, 2026
4 checks passed
@nperez0111
Copy link
Contributor Author

Thanks for the quick review & publish @pi0!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants