Conversation
📝 WalkthroughWalkthroughThe pull request bumps the srvx dependency from ^0.7.1 to ^0.10.1, extends PNPM configuration with onlyBuiltDependencies, and consolidates type imports across server modules from "srvx/types" to "srvx" while removing TypeScript type assertion suppressions. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 0
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
package.json (1)
99-106: Consider updating the peerDependency minimum version.The peerDependency still allows
>=0.7.1, but the codebase now imports types from"srvx"instead of"srvx/types". Users on srvx versions <0.8.0 may encounter type resolution failures since those older versions still export types from the/typessubpath.Consider bumping to
>=0.8.0or>=0.10.0to ensure compatibility.
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
|
Thanks for the quick review & publish @pi0! |
I was getting some type resolution issues because as of srvx@0.8.0 the
/typessubpath has been removed. The current version of the package attempts to resolve against that & ends up not being able to resolve it since the subpath no longer exists.Everything still works at runtime though, so I'm submitting this to just bump the dependency, so we can get the type resolution working again.
Thanks for your consideration, I really appreciate all of these packages & am using
crosswsas the basis for my Y.js sync server, Teleportal!Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.