Skip to content

Fix MKV hw encode issue #150

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 7, 2025
Merged

Fix MKV hw encode issue #150

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
82bc3e3
Fix MKV hw encode issue
btmxh Mar 30, 2025
1aa095e
Set global header using C++ API instead of C
btmxh Apr 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions example/api2-samples/api2-hw-encode.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,6 @@
*
* Thanks to https://github.com/mojie126, for more-less complete sample.
*
* Known issues: error on the Matroska header writing.
*
*/


Expand Down Expand Up @@ -155,6 +153,11 @@ int main(int argc, char **argv) {
encoder.setTimeBase(Rational{1, 1000});
encoder.setBitRate(vdec.bitRate());

// MKV format wants global header, so
// this fixes the issue with MKV container
if (ofrmt.flags() & AVFMT_GLOBALHEADER)
encoder.addFlags(AV_CODEC_FLAG_GLOBAL_HEADER);

encoder.open(Codec(), ec);
if (ec) {
cerr << "Can't opent encodec\n";
Expand Down
Loading