Skip to content
This repository was archived by the owner on Jan 23, 2026. It is now read-only.

Conversation

@nogaems
Copy link
Contributor

@nogaems nogaems commented Mar 18, 2019

While working on a feature #19 I've faced a problem of not being able to have two+ identical nicknames due to the internal representation of WeeChat's nicklist (i.e. struct t_gui_nick *weechat_nicklist_search_nick(...) always returns a single pointer and prefixes don't change anything).
I've managed to get a user Tox ID's public key part via the API like you've mentioned previously, so I just basically put it (shortened version, using option tox.look.short_id_size) in front of nicknames so that all the nicknames are different now. Also I had to implement the nickname completion because of that. The displaying of short ids in chat logs and presence messages may be disabled using tox.look.show_id. clang-format is already applied.
On top of this feature I can finally finish #19 in a proper way.

@nogaems nogaems force-pushed the nickname_disambiguation branch 4 times, most recently from 21fe443 to f6ac280 Compare March 27, 2019 02:13
@nogaems nogaems force-pushed the nickname_disambiguation branch from ee56d07 to fe55894 Compare March 27, 2019 03:25
@haavard haavard self-assigned this Mar 31, 2019
@haavard haavard self-requested a review March 31, 2019 13:48
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants