Skip to content

Conversation

@bbarni2020
Copy link
Collaborator

No description provided.

Copilot AI review requested due to automatic review settings December 23, 2025 23:08
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR implements a memory optimization feature for the explore page by limiting the number of loaded devlogs in memory. When the number of devlogs exceeds 60, the oldest 15 are removed (trimming back to 45) while preserving the user's scroll position.

Key changes:

  • Added automatic trimming of old devlogs to prevent unlimited memory growth
  • Implemented scroll position preservation when removing devlogs from the DOM
  • Set maximum devlogs limit to 60 with trimming threshold at 45

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Collaborator

@ArcaEge ArcaEge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This just gets rid of the devlogs at the top and they don't return if you scroll back up. Instead it should check the intersectionobserver and just completely unmount the Spinny3DPreview if it's scrolled way past, the devlog itself can be kept in place to avoid messing with the dom

@bbarni2020
Copy link
Collaborator Author

Kk, on it

@bbarni2020 bbarni2020 requested a review from ArcaEge December 30, 2025 00:11
@bbarni2020
Copy link
Collaborator Author

Done

@ArcaEge
Copy link
Collaborator

ArcaEge commented Dec 30, 2025

I'll have a look this evening

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants