fix: project labels table not being created #465
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nystar1
force-pushed
the
migration-for-project-labels
branch
from
f019a06 to
e967d8d
Compare
maxwofford
reviewed
Aug 8, 2025
| t.timestamps | ||
| end | ||
|
|
||
| add_index :project_labels, [ :user_id, :project_key ], unique: true |
There was a problem hiding this comment.
Check indentation- run the formatter!
maxwofford
reviewed
Aug 8, 2025
| class CreateProjectLabels < ActiveRecord::Migration[8.0] | ||
| # where was ts before? | ||
| def change | ||
| create_table :project_labels do |t| |
There was a problem hiding this comment.
if our code is out of sync with production database, our code should support handling the unknown! Check out https://blog.saeloun.com/2020/02/10/rails-support-for-if-exists-if-not-exists-on-remove-column-add-column-in-migrations/
|
I left some comments, but overall thanks for the submission! I'm traveling right now, so cc @3kh0 for reviewing and merging this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
context: setting up dev environment broken because project labels table is not created by default but the code expects & uses it
reason: table was prob directly created in postgres rather than through a migration & schema was never synced