Follow up to UX issues with contract signee invitation #11011
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This way we can show the cosigner email field only when "Contract Signee" is selected and not when the prompt option (or "won't sign the contract") is currently selected
We were still protected from this issue by https://github.com/hackclub/hcb/blob/9c9a8cbca4c8b5b512e998d07b1597030e8f9cd9/app/models/concerns/organizer_position/has_role.rb#L21-L26 But now that the UI hides the contract signee question unless you are inviting a manager, this improves the UX if you happen to be on manager, selected contract signee, then change to reader or member without changing the contract signee status.
|
That behavior is perfect! Thank you |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the problem
Follow up to UX issues noted in #10982 (comment)
Describe your changes
Now we only show the contract sub form if the invited user is a manager. This raises a small issue where you could have Manager selected, then set them to be a contract signee, then change the role to Reader or Member and try to submit. This would do the right thing and result in an error, but I think is confusing UX, so I changed the backend to only honor the
is_signeefield when Manager is the selected role.An alternative would have been to clear the contract signee form in the frontend when switching roles, but I think sanitizing params in the backend was easier in this case.
I didn't realize we were using alpinejs for this form, we might want to consider removing the stimulus controller I added for hiding and using alpinejs for that too.
We now only show the cosigner option when "Contract Signee" is selected. This was implemented by changing
form_hide_field_controllerto take the option we want to show the conditional field on, not the ones we want to hide on.This one I left as is for now as it might be intentional/desired behavior.
@garyhtou can you confirm whether this is fine, or should we consider setting a default option for the regular invite flow? This would make it easier to remove the prompt option in both places we are using this