[Announcement] Add new UI for block adding and editing #11073
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
just merged main into this PR and added the validation to display in the block modal - thanks for reminding me! |
sampoder
requested changes
Aug 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the problem
The built-in browser modal for submitting data about blocks isn't great, and currently you can't edit the parameters of a block without removing it and adding it again. :(
Describe your changes
This PR adds custom modals to add/edit the data of a block, for now all except
DonationGoal. To allow this, creating new announcements using a modal has been removed, as modals cannot be easily layered. Clicking on the create button will just direct to theannouncements/newpage.Some refactoring has also been done to the block database structure and Stimulus controllers to make rendering them in different contexts (like a turbo stream) easier and with less code.
Screencast.From.2025-07-23.15-21-23.mp4